[generator] Deriving from certain protocol interfaces generates uncompilable code. Fixes bug 52665 #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pilable code. Fixed bug 52665
Some namespaces are missing on generated files, causing error CS0246
The type or namespace name `Foo` could not be found.
While fixing this another error arose, by enabling the following test
[Protocol] interface C140 : ICIImageProcessorInput {}
some codepaths leads to CVPixelBuffer creation which our code
tries to invoke the handle ctor and fails to find it because it
is internal. This will be fixed in a different commit.
|
Build success |
spouliot
approved these changes
May 18, 2017
rolfbjarne
reviewed
May 18, 2017
src/generator.cs
Outdated
| @@ -717,6 +717,19 @@ public NamespaceManager (string prefix, string customObjCRuntimeNS, bool skipSys | |||
| if (Frameworks.HaveMetal && !(Generator.CurrentPlatform == PlatformName.MacOSX && !Generator.UnifiedAPI)) | |||
| ImplicitNamespaces.Add (Get ("Metal")); | |||
|
|
|||
| if (Frameworks.HaveCoreImage && !(Generator.CurrentPlatform == PlatformName.WatchOS)) | |||
There was a problem hiding this comment.
Why do you need the additional platform checks?
In the code above they're only there to not change the generated output when I ported the code to use IKVM; in theory those checks can be removed (but when porting to IKVM I preferred fixing one thing at a time, minimizing the diff in the generated output).
There was a problem hiding this comment.
Good point, It would be cleaner/simpler without them 👍
|
@rolfbjarne / @spouliot Fixed 👍 |
rolfbjarne
approved these changes
May 18, 2017
spouliot
approved these changes
May 18, 2017
There was a problem hiding this comment.
much nicer:)
@dalexsoto at a lower priority (after 15.3 issues) can you do a separate PR to remove the other extra conditions. thanks!
|
@spouliot noted, will do! |
|
Build success |
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
May 19, 2017
… from 3rd party bindings Complements https://bugzilla.xamarin.com/show_bug.cgi?id=52665 and PR xamarin#2102 CVPixelBuffer was created using the internal handle ctor, this did not allow 3rd party bindings to bind it correctly since it generated not compilable code. We now use Runtime.GetINativeObject<CVPixelBuffer> (ptr, false); just like the base ctor https://git.io/vHvLj.
dalexsoto
added a commit
that referenced
this pull request
May 19, 2017
… from 3rd party bindings (#2111) * [generator] Create CVPixelBuffer using GetINativeObject so its usable from 3rd party bindings Complements https://bugzilla.xamarin.com/show_bug.cgi?id=52665 and PR #2102 CVPixelBuffer was created using the internal handle ctor, this did not allow 3rd party bindings to bind it correctly since it generated not compilable code. We now use Runtime.GetINativeObject<CVPixelBuffer> (ptr, false); just like the base ctor https://git.io/vHvLj. * [tests] Add IntPtr.Zero check and fix link in code * [generator] Make comment easier to find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some namespaces are missing on generated files, causing error CS0246
The type or namespace name
Foocould not be found.While fixing this another error arose, by enabling the following test
[Protocol] interface C140 : ICIImageProcessorInput {}some code paths lead to CVPixelBuffer creation which our code
tries to invoke the handle ctor and fails to find it because it
is internal. This will be fixed in a different commit.
build diff: https://gist.github.com/dalexsoto/055381e7aebecca254139bd6cca6a2e8