New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios11-beta1] Initial UIKit Drag and Drop support #2190
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
30d911a
[ios11-beta1] Initial UIKit Drag and Drop support
migueldeicaza 94f7013
Updated with Feedback from Rolf
migueldeicaza 4849fa7
Updated with Feedback from Tim Risi, inlined in the implementing clas…
migueldeicaza 3c56df8
NSItemProviderReading inlined methods get availability attributes
migueldeicaza 14d9105
UIDropInteraction only has a getter Delegate method
migueldeicaza fcb81d9
UIDropInteraction - without the delegate setter, we can not provide e…
migueldeicaza 8a44db7
Ignore what the header files say, the NSItemProviderReading methods a…
migueldeicaza 0643d17
Add 'Editability' as an acceptable word
migueldeicaza 6c87a94
Address Alex Soto's feedback
migueldeicaza 897f203
Rename some methods, fix types
migueldeicaza 631e676
Add Emacs backup files to .gitignore
migueldeicaza File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,5 @@ xammac.csproj | |
xamtvos.csproj | ||
xamwatch.csproj | ||
generator-ikvm.csproj | ||
~.pmcs-* | ||
*~ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the method being bound separately in the different classes instead of having the classes implement INSItemProviderReading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See bug: https://bugzilla.xamarin.com/show_bug.cgi?id=57650 for details.
The runtime needs some changes to support the idiom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I've stated on the bug I believe the runtime doesn't need changes to make it work, so this can be uncommented (and the CreateFrom method should be a proper Constructor, not a method).
The registrars can provide some help for users, but it needs these methods properly defined in order to have enough information to help users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this patch does is to inline the constructor in all three places that conform to this procotol.
I tried doing what you suggested (a) removing the above line, and (b) removing the inlined constructors that this patch contains everywhere and (c) making those classes adopt the NSItemProviderReading interface, but that does not inline the constructor anywhere, nor does the interface gain anything out of having this method declared here.
The result is thus a step backwards, the patch to that is here:
https://gist.github.com/migueldeicaza/e22f44007e7ac093a0076276187dcb16
So I am not sure what is that you are suggesting I do with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant only uncommenting the code here, inside
NSItemProviderReading
, not removing the inlined members elsewhere.In any case I can fix this when I look at the corresponding bug.