[registrar] Don't verify the SDK for protocol members, and fix the SDK check for other cases. Fixes #59617. #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be fetched from the Target. Partially fixes #59617. This avoids a problem where our code would store null because LinkContext wasn't created yet when the static registrar instance was created. This fixes the missing error from bug #59617. https://bugzilla.xamarin.com/show_bug.cgi?id=59617
…s #59617. It's not needed, because protocol members don't end up in the registrar output anyway (and would thus not prevent the registrar code from compiling). Classes that implement any protocol members would still run into the SDK check, so this should not prevent real problematic code from being reported either. https://bugzilla.xamarin.com/show_bug.cgi?id=59617
chamons
approved these changes
Sep 27, 2017
|
Looks like this fixes bug #59177 too. |
|
Build failure |
|
Build success |
spouliot
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.xamarin.com/show_bug.cgi?id=59617