Incrementally bump mono #3106
Closed
Incrementally bump mono #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoveTaskBase inherits from Microsoft.Build.Tasks.Move, and Mono has a different implementation of it, so when building from a Mac we need to include XBuildMoveTaskBase.cs instead. The previous condition does no apply any more, because we're now using MSBuild to build, but the Move task implementation didn't change so it doesn't matter if we're using Xbuild or MSBuild. This issue is preventing us (XVS) from merging features to our master branch
Commit list for mono/mono: * mono/mono@b3b0613ad38 Bump msbuild to bring in fix for #60770 (xamarin#6107) * mono/mono@ddeba6e1bab [interp] fix using conv.u with string * mono/mono@0360f420fe3 Bump API snapshot submodule * mono/mono@2f18e7dd23c Bump cecil & linker to match master. * mono/mono@0f53cb275c4 [interp] allow unsigned i8 in pinvoke signature Diff: mono/mono@c5cd0f1...b3b0613 https://bugzilla.xamarin.com/show_bug.cgi?id=60770
spouliot
requested review from
emaf,
jstedfast,
kzu,
rolfbjarne and
VincentDondain
as code owners
spouliot
added
do-not-merge
|
Build failure |
|
Build failure |
|
Build failure |
|
Build failure |
|
no doubt, the issues starts with the bump from 2f18e7 |
|
binary search inside that bump won't be done by this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit list for mono/mono:
Diff: mono/mono@c5cd0f1...b3b0613
https://bugzilla.xamarin.com/show_bug.cgi?id=60770