[monotouch-tests] Adds mono's WeakAttribute tests (Backport) #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [monotouch-tests] Adds mono's WeakAttribute tests * Embrace watchOS Unfortunately this revealed that WeakAttribute is not working for watchOS * Port mono's WeakAttribute test to our test runner Test Ported: https://github.com/mono/mono/blob/5bdaef7e5f6479cc4336bb809b419e85ad706dd7/mono/tests/weak-fields.cs * Fix object leaks and implement suggested approach from 4b9ade0 * Remove debug spew and fix formating on header
|
Build success |
spouliot
approved these changes
Mar 16, 2018
VincentDondain
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[monotouch-tests] Adds mono's WeakAttribute tests
Embrace watchOS
Unfortunately this revealed that WeakAttribute is not working for watchOS
Test Ported:
https://github.com/mono/mono/blob/5bdaef7e5f6479cc4336bb809b419e85ad706dd7/mono/tests/weak-fields.cs
Fix object leaks and implement suggested approach from 4b9ade0
Remove debug spew and fix formating on header