Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFNetwork] Ensure we do not block on redirects. #5900

Commits on Apr 15, 2019

  1. [CFNetwork] Ensure we do not block on redirects.

    The changes in mono are changing threading. This means that the code is
    getting deadlock in the ReadStreamData.
    
    This happens because we were not removing the handlers from the first requests events.
    Initially, before we had to take care about the auth headers, this was needed to init
    certain internal state for the HttpContent that was sexposed to the
    user. With the fix of the CVE, the first request, in case of a redirect,
    is garbage and is ignored. The second request is the one returned to the
    user and contains all the required info.
    
    Removing the event handlers, ensure that HandleClose is not called and
    therefore ReadStream is never called.
    mandel-macaque committed Apr 15, 2019
    Copy the full SHA
    403e8e7 View commit details
    Browse the repository at this point in the history