Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[appkit] Add NullAllowed to AppKit Tooltip properties #6113

Merged
merged 1 commit into from May 23, 2019
Merged

[appkit] Add NullAllowed to AppKit Tooltip properties #6113

merged 1 commit into from May 23, 2019

Conversation

chamons
Copy link
Contributor

@chamons chamons commented May 23, 2019

@chamons chamons requested a review from dalexsoto as a code owner May 23, 2019 14:27
@chamons
Copy link
Contributor Author

chamons commented May 23, 2019

The matrix version wasn't in the issue but I checked the tooltip setting APIs in appkit.cs against the header while I was here.

We really should look at extending xtro for NullAllowed at some point.

@spouliot
Copy link
Contributor

@chamons it's easy to add in xtro - but it's harder to do when we have pending branches (like xcode*) since it's a merge hell.

In fact this commit (and other binding fixes in master post d16-2) should be back ported into xcode11 to ease merging.

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@chamons chamons merged commit a989607 into xamarin:master May 23, 2019
@chamons chamons deleted the NSView_Tooltip_Null branch May 23, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therzok Therzok Therzok approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chamons @spouliot @monojenkins @Therzok @rolfbjarne