Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UIKit] Updated UIKit to xcode8-beta6 #636

Merged
merged 1 commit into from Aug 22, 2016
Merged

[UIKit] Updated UIKit to xcode8-beta6 #636

merged 1 commit into from Aug 22, 2016

Conversation

dalexsoto
Copy link
Member

@dalexsoto dalexsoto commented Aug 19, 2016 •
edited

Expected extrospection test failures:

  • ios.unclassified:!missing-field! UIApplicationInvalidInterfaceOrientationException not bound

Some Generator bugs encountered:

  • HACK: We have a generator bug(?) that won't allow overloads (AmbiguousMatchException) in protocols

tvOS/iOS 9 Introspection Expected failures (UIKit Only):

  • [FAIL] UIKit.UIContentSizeCategoryExtensions.UIContentSizeCategoryUnspecified

Generated enum extensions do not honor availability on NSString properties

API Diff, expected changes (verified and correct):

Type Changed: UIKit.UIContentSizeCategory

Modified fields:

ExtraExtraExtraLarge = 6 7
ExtraExtraLarge = 5 6
ExtraLarge = 4 5
ExtraSmall = 0 1
Large = 3 4
Medium = 2 3
Small = 1 2

Added values:

AccessibilityExtraExtraExtraLarge = 12,
AccessibilityExtraExtraLarge = 11,
AccessibilityExtraLarge = 10,
AccessibilityLarge = 9,
AccessibilityMedium = 8,
Unspecified = 0,

dalexsoto
dalexsoto reviewed Aug 19, 2016
View reviewed changes
src/uikit.cs
interface UITextContentType {
[Field ("UITextContentTypeName")]
NSString Name { get; }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the diff noise below but it did look awful on the IDE

@spouliot
Copy link
Contributor

Those starts with UI but not UIKit related

  • osx.unclassified:!missing-pinvoke! UInt64ToLongDouble is not bound
  • osx.unclassified:!missing-pinvoke! UInt64ToSInt64 is not bound

Generated enum extensions do not honor availability on NSString properties

Got a local patch for that, found out while pending Security stuff. I'll commit that asap.

I'll review the diff later.

spouliot
spouliot reviewed Aug 20, 2016
View reviewed changes
src/UIKit/UIAccessibility.cs
public static bool IsAssistiveTouchRunning {
get {
return UIAccessibilityIsAssistiveTouchRunning ();
}
}

#if !TVOS
[iOS (10,0), TV (10,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really ? because it's under !TVOS and I'm fairly sure strong pointed them as unavailable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha my bad :P good catch

@monojenkins
Copy link
Collaborator

Build success

@monojenkins
Copy link
Collaborator

Build success

spouliot
spouliot reviewed Aug 21, 2016
View reviewed changes
src/uikit.cs
[Abstract]
[Export ("itemTitleForCloudSharingController:")]
[return: NullAllowed]
string ItemTitle (UICloudSharingController csc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefix Get

@spouliot
Copy link
Contributor

From API diff

Type Changed: UIKit.UIContentSizeCategory

Modified fields:

ExtraExtraExtraLarge = 6 7
ExtraExtraLarge = 5 6
ExtraLarge = 4 5
ExtraSmall = 0 1
Large = 3 4
Medium = 2 3
Small = 1 2

Added values:

AccessibilityExtraExtraExtraLarge = 12,
AccessibilityExtraExtraLarge = 11,
AccessibilityExtraLarge = 10,
AccessibilityLarge = 9,
AccessibilityMedium = 8,
Unspecified = 0,

^ please double check the modified values. If right please add this info to the commit message (so we don't end up reviewing this too many times)

@dalexsoto
[UIKit] Updated UIKit to xcode8-beta6
01a94f4 
Expected extrospection test failures:

- ios.unclassified:!missing-field! UIApplicationInvalidInterfaceOrientationException not bound

Generator bugs:

- HACK: We have a generator bug(?) that won't allow overloads (AmbiguousMatchException) in protocols

tvOS/iOS 9 Introspection Expected failures (UIKit Only):

- [FAIL] UIKit.UIContentSizeCategoryExtensions.UIContentSizeCategoryUnspecified
Generated enum extensions do not honor availability on NSString properties

API Diff, expected changes (verified and correct):

Type Changed: UIKit.UIContentSizeCategory

Modified fields:

	ExtraExtraExtraLarge = 6 7
	ExtraExtraLarge = 5 6
	ExtraLarge = 4 5
	ExtraSmall = 0 1
	Large = 3 4
	Medium = 2 3
	Small = 1 2

Added values:

	AccessibilityExtraExtraExtraLarge = 12,
	AccessibilityExtraExtraLarge = 11,
	AccessibilityExtraLarge = 10,
	AccessibilityLarge = 9,
	AccessibilityMedium = 8,
	Unspecified = 0,
@monojenkins
Copy link
Collaborator

Build failure

@dalexsoto
Copy link
Member Author

build

seems that classic timed out

@monojenkins
Copy link
Collaborator

Build success

@spouliot spouliot merged commit 16d5d68 into xamarin:xcode8 Aug 22, 2016
@spouliot
Copy link
Contributor

The tvOS/iOS 9 Introspection Expected failures should be fixed when I push my generator/enum fix.

spouliot added a commit to spouliot/xamarin-macios that referenced this pull request Aug 22, 2016
@spouliot
[generator] Move availability attributes on enums/fields where our te…
0ae0497 
…sts will see them

Needed for *upcoming* Security.framework bindings and also needed
to fix an error error reported on UIKit [1]

[1] xamarin#636
@spouliot spouliot mentioned this pull request Aug 22, 2016
Merged
spouliot added a commit that referenced this pull request Aug 22, 2016
@spouliot
[generator] Move availability attributes on enums/fields where our te…
42ecb6f 
…sts will see them (#640)

Needed for *upcoming* Security.framework bindings and also needed
to fix an error error reported on UIKit [1]

[1] #636
@dalexsoto dalexsoto deleted the uikit branch August 24, 2016 05:25
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Feb 13, 2018
@rolfbjarne
[mmp] Restrict the blockliterla-setupblock optimization to Unified. F…
70c147b 
…ixes maccore xamarin#636.

XamMac.dll is not built anymore, so it doesn't have the new managed API to make the optimization work.

Fixes xamarin/maccore#636.
rolfbjarne added a commit that referenced this pull request Feb 13, 2018
@rolfbjarne
[mmp] Restrict the blockliterla-setupblock optimization to Unified. F…
5933c2d 
…ixes maccore #636. (#3468)

XamMac.dll is not built anymore, so it doesn't have the new managed API to make the optimization work.

Fixes xamarin/maccore#636.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dalexsoto @spouliot @monojenkins @dnfclas