[NotificationCenter] Bindings for iOS Xcode 11 beta 1 #6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joconte
commented
Jul 13, 2019
joconte
commented
Jul 13, 2019
joconte
commented
Jul 13, 2019
rolfbjarne
requested changes
Jul 15, 2019
There was a problem hiding this comment.
You must also remove this file, so that our xtro tests pass: https://github.com/xamarin/xamarin-macios/blob/xcode11/tests/xtro-sharpie/iOS-NotificationCenter.todo
Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
Change deprecated message because I changed the method name
spouliot
suggested changes
Jul 15, 2019
|
@rolfbjarne @spouliot |
joconte
commented
Jul 15, 2019
spouliot
approved these changes
Jul 15, 2019
dalexsoto
approved these changes
Jul 15, 2019
dalexsoto
added
community
|
build |
|
Build failure Test results1 tests failed, 90 tests passed.Failed tests
|
|
@joconte missing a selector on iOS UIVibrancyEffect::widgetEffectForVibrancyStyle |
joconte
commented
Jul 16, 2019
mandel-macaque
changed the title
mandel-macaque
changed the title
spouliot
suggested changes
Jul 16, 2019
…m/joconte/xamarin-macios into xcode11-NotificationCenter-iOS-b1
|
build |
1 similar comment
|
build |
|
Build success |
spouliot
approved these changes
Jul 16, 2019
|
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to give a try to Notification Center Bindings for iOS beta 1
diff : https://github.com/xamarin/xamarin-macios/wiki/NotificationCenter-iOS-xcode11-beta1