Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HealthKit] updates for beta 1 - beta 4 xcode11 #6692

Merged
merged 11 commits into from
Aug 2, 2019
Merged

[HealthKit] updates for beta 1 - beta 4 xcode11 #6692

merged 11 commits into from
Aug 2, 2019

Conversation

whitneyschmidt
Copy link
Contributor

Accidentally added extra changes to #6647

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

22 tests failed, 69 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • link all/iOS Unified 32-bits - simulator/Debug: Failed
  • link all/iOS Unified 32-bits - simulator/Release: Failed
  • link sdk/iOS Unified 32-bits - simulator/Debug: Failed
  • link sdk/iOS Unified 32-bits - simulator/Release: Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • link all/iOS Unified 64-bits - simulator/Debug: Failed
  • link all/iOS Unified 64-bits - simulator/Release: Failed
  • link sdk/iOS Unified 64-bits - simulator/Debug: Failed
  • link sdk/iOS Unified 64-bits - simulator/Release: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • link all/tvOS - simulator/Debug: Failed
  • link all/tvOS - simulator/Release: Failed
  • link sdk/tvOS - simulator/Debug: Failed
  • link sdk/tvOS - simulator/Release: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

@whitneyschmidt
Copy link
Contributor Author

build

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

22 tests failed, 69 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • link all/iOS Unified 32-bits - simulator/Debug: Failed
  • link all/iOS Unified 32-bits - simulator/Release: Failed
  • link sdk/iOS Unified 32-bits - simulator/Debug: Failed
  • link sdk/iOS Unified 32-bits - simulator/Release: Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • link all/iOS Unified 64-bits - simulator/Debug: Failed
  • link all/iOS Unified 64-bits - simulator/Release: Failed
  • link sdk/iOS Unified 64-bits - simulator/Debug: Failed
  • link sdk/iOS Unified 64-bits - simulator/Release: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • link all/tvOS - simulator/Debug: Failed
  • link all/tvOS - simulator/Release: Failed
  • link sdk/tvOS - simulator/Debug: Failed
  • link sdk/tvOS - simulator/Release: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

dalexsoto
dalexsoto requested changes Aug 1, 2019
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes

src/HealthKit/Enums.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

10 tests failed, 81 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

dalexsoto
dalexsoto approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 more heh

src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

10 tests failed, 81 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

10 tests failed, 81 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

mandel-macaque
mandel-macaque requested changes Aug 2, 2019
View reviewed changes
src/healthkit.cs Outdated Show resolved Hide resolved
@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@whitneyschmidt whitneyschmidt merged commit 7b63a38 into xamarin:xcode11 Aug 2, 2019
@whitneyschmidt whitneyschmidt added iOS Issues affecting Xamarin.iOS note-highlight Worth calling out specifically in release notes labels Sep 9, 2020
@whitneyschmidt whitneyschmidt added this to the xcode11 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot Awaiting requested review from spouliot

@VincentDondain VincentDondain Awaiting requested review from VincentDondain VincentDondain is a code owner

Assignees
No one assigned
Labels
iOS Issues affecting Xamarin.iOS note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@whitneyschmidt @monojenkins @dalexsoto @mandel-macaque