[mediaaccessibility] Update for Xcode 11 beta 5 #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexsoto
approved these changes
Aug 7, 2019
whitneyschmidt
approved these changes
Aug 7, 2019
| // CFAttributedString is “toll-free bridged” with its Foundation counterpart, NSAttributedString. | ||
| // https://developer.apple.com/documentation/corefoundation/cfattributedstring?language=objc | ||
| if ((strings == null) || (strings.Length == 0)) | ||
| MACaptionAppearanceDidDisplayCaptions (IntPtr.Zero); |
There was a problem hiding this comment.
Why do we use IntPtr.Zero in place of null?
There was a problem hiding this comment.
It's basically all the same, just like 0 would be - but
- C# is type safe (unlike C/C++); and
IntPtris astructnot a reference type so it can't be set tonull; and
We could use pointers in C# but that would expose a lot of unsafe code everywhere... which does not make great API.
We could have a 2nd [DllImport] with a different signature - but that would bloat the code.
There was a problem hiding this comment.
Thank you for the detailed explanation, makes a lot of sense! ❤️
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.