[Device tests] Bump maccore to fix device tests. #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump maccore to get a fix in the launch.sh script that pings the device tests.
prmallic
approved these changes
Jan 6, 2020
prmallic
approved these changes
Jan 6, 2020
| @@ -7,7 +7,7 @@ MONO_BRANCH := $(shell cd $(MONO_PATH) 2> /dev/null && git symbolic-ref --sho | |||
| endif | |||
|
|
|||
| ifdef ENABLE_XAMARIN | |||
| NEEDED_MACCORE_VERSION := 113cf2ad61ee0ecf9affde6ebae7804744f47933 | |||
| NEEDED_MACCORE_VERSION := b2d37c77cc34558a67fd328cf886ca00ba413db4 | |||
There was a problem hiding this comment.
Should this also be backported to other branches?
There was a problem hiding this comment.
I need to check the DDFun stuff, AFAIK no, but we can take a look at the tvOS jobs and decide.
dalexsoto
approved these changes
Jan 6, 2020
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump maccore to get a fix in the launch.sh script that pings the device
tests.