[mtouch/mmp] Build and run mtouch and mmp using dotnet. #8461
Conversation
Referencing the dotnet-built mmp.dll from a non-dotnet-built mmptest doesn't work, so upgrade mmptest to use dotnet.
…lling pkg-config. It seems either our testing framework or dotnet can set it, and it confuses pkg-config.
…le if it exists. The copyfile method does not like copying files over an existing file, and sometimes it may end up showing an error.
rolfbjarne
added
the
note-highlight
|
It might be possible to not require dotnet, by using the system mono and something like this in the bin script: ...
# Run with mono if we can find mono.
if type mono >/dev/null 2>&1; then
echo Using mono
exec mono $MONO_OPTIONS "$MONOTOUCH_PREFIX/lib/mtouch/mtouch.dll" "$@"
else
echo Using dotnet
exec "$MONOTOUCH_PREFIX/lib/mtouch/mtouch" "$@"
fi |
|
@rolfbjarne it then becomes a testing issue, each runtime with a range of versions :( Right now we still need mono for what ? |
|
Build failure Test results5 tests failed, 84 tests passed.Failed tests
|
|
build |
|
Build failure Test results1 tests failed, 88 tests passed.Failed tests
|
… of modifying 'BuildDependsOn'. The dotnet build logic will re-overwrite 'BuildDependsOn' and remove our changes, so try a more reliable way instead.
|
Did you look at multi-targetting the tools and only using the netcore version for .net 5? |
|
Build success |
| @@ -88,7 +89,18 @@ public async Task CreateCopyAsync (ITestTask test = null) | |||
| doc.SetNode ("DocumentationFile", "bin\\$(Configuration)\\nunitlite.xml"); | |||
| } | |||
| doc.ResolveAllPaths (original_path); | |||
|
|
|||
| if (doc.IsDotNetProject ()) { | |||
There was a problem hiding this comment.
I'll have to move this to dotnet/xharness, created an issue not to forget: dotnet/xharness#128
| @@ -195,7 +195,7 @@ public static void SetIntermediateOutputPath (this XmlDocument csproj, string va | |||
| // Make sure there's a top-level version too. | |||
| var property_group = csproj.SelectSingleNode("/*/*[local-name() = 'PropertyGroup' and not(@Condition)]"); | |||
|
|
|||
| var intermediateOutputPath = csproj.CreateElement ("IntermediateOutputPath", MSBuild_Namespace); | |||
| var intermediateOutputPath = csproj.CreateElement ("IntermediateOutputPath", csproj.GetNamespace ()); | |||
There was a problem hiding this comment.
Same, issue: dotnet/xharness#128
|
Closing, this will probably be done a bit differently in the end. |
Compatibility: these tools now require dotnet 3.1 (or later) to be installed
before they'll work.
There are a few seemingly unrelated changes: these were required because some
of the tests would fail otherwise.