Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mediasetup] Update for Xcode 12 beta 2 #9087

Merged
merged 3 commits into from
Jul 17, 2020
Merged

[mediasetup] Update for Xcode 12 beta 2 #9087

merged 3 commits into from
Jul 17, 2020

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Jul 14, 2020 •
edited
Loading

The framework is not available (binary or even headers) for the iOS
simulator, only devices.

As such tools/mtouch/Makefile is not updated with a -weak-framework

Tracked with

[mediasetup] Update for Xcode 12 beta 2
69e2daa 
The framework is not available (binary or even headers) for the iOS
simulator, only devices.

As such `tools/mtouch/Makefile` is not updated with a `-weak-framework`

Tracked with
* https://github.com/xamarin/maccore/issues/2266
* https://feedbackassistant.apple.com/feedback/8001312
@spouliot spouliot changed the title [pushkit] Update for Xcode 12 beta 2 (Catalyst only) [mediasetup] Update for Xcode 12 beta 2 Jul 14, 2020
@spouliot spouliot mentioned this pull request Jul 14, 2020
Open
46 tasks
@spouliot spouliot added this to the xcode12 milestone Jul 14, 2020
mandel-macaque
mandel-macaque requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mediasetup.cs?

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

17 tests failed, 79 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • framework-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • interdependent-binding-projects/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • dont link/iOS Unified 32-bits - simulator/Release: BuildFailure
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • dont link/iOS Unified 64-bits - simulator/Release: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • dont link/watchOS 32-bits - simulator/Release: BuildFailure
  • link all/watchOS 32-bits - simulator/Release: BuildFailure
  • link sdk/watchOS 32-bits - simulator/Release: BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
  • MSBuild tests/iOS (net461): Failed (Execution failed with exit code 24)
  • MSBuild tests/iOS (netstandard2.0): Failed (Execution failed with exit code 24)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 25)

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@spouliot spouliot merged commit 486ded9 into xamarin:xcode12 Jul 17, 2020
@spouliot spouliot deleted the xcode12-mediasetup-b2 branch July 17, 2020 00:34
@pdonovan
Copy link

This still doesn't work with the GM of Xcode 12, VS Mac Version 8.7.6 (build 19) and Xamarin.iOS 13.99.0.251.

Are there any temporary workarounds I can do to get our app building for the simulator again? Even if it means temporarily ripping out some parts (I don't know what MediaSetup is used for)?

@praeclarum
Copy link
Contributor

I'm hitting this too when building for simulator.

@rolfbjarne
Copy link
Member

@praeclarum hitting what exactly? do you have a build log?

@pdonovan
Copy link

I've attached part of the build log that seems to be pertinent to the problem.
mediasetuperror.txt

@praeclarum
Copy link
Contributor

Sorry @rolfbjarne, I had an edit that I don't seem to have saved.

There was an issue in the simulator where it kept trying to link with MediaSetup even though the sim doesn't support it.

Fortunately, the stable build released yesterday fixes it. So you can disregard my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@chamons chamons Awaiting requested review from chamons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
xcode12
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@spouliot @monojenkins @pdonovan @praeclarum @rolfbjarne @dalexsoto @mandel-macaque @whitneyschmidt