[Xcode12][GameKit] Update for beta 1-2 #9126

whitneyschmidt · 2020-07-17T18:51:46Z

No description provided.

spouliot · 2020-07-17T19:05:47Z

src/GameKit/GKLeaderboardSet.cs

+			if (UIKit.UIDevice.CurrentDevice.CheckSystemVersion (14, 0))
+#elif WATCH
+			if (WatchKit.WKInterfaceDevice.CurrentDevice.CheckSystemVersion (7, 0))
+#elif MONOMAC


there's a #if !MONOMAC earlier

spouliot · 2020-07-17T19:06:08Z

src/GameKit/GKLeaderboardSet.cs

+namespace GameKit {
+	public partial class GKLeaderboardSet {
+
+		public void LoadLeaderboardsWithHandler (GKLeaderboardsHandler completionHandler)


remove WithHandler since it's implied

ideally there would be a [Async] version of the API
It will need to be manually added in this case

Unfortunately there's already an API named LoadLeaderboards in GKLeaderboardSet namespace.

The group of related APIs have this (not great) naming scheme:

LoadLeaderboards - deprecated, generated

LoadLeaderboardsWithCompletionHandler - new! generated

LoadLeaderboardsWithHandler - new! manual wrapper for the above

So we can change the names of 2 & 3 but not 1.

Ideas for other names very welcome!

are the parameter names blocking the use of overloads ?
if so then I don't have any better idea atm

Yep, they all have the same signature, (GKLeaderboardsHandler completionHandler) 😕

src/GameKit/GameKit.cs

spouliot · 2020-07-17T19:09:41Z

tests/xtro-sharpie/iOS-GameKit.ignore

@@ -32,3 +32,6 @@
 !missing-null-allowed! 'UIKit.UIViewController GameKit.GKAchievement::ChallengeComposeController(GameKit.GKPlayer[],System.String,GameKit.GKChallengeComposeHandler)' is missing an [NullAllowed] on parameter #0
 !missing-null-allowed! 'UIKit.UIViewController GameKit.GKAchievement::ChallengeComposeController(GameKit.GKPlayer[],System.String,GameKit.GKChallengeComposeHandler)' is missing an [NullAllowed] on return type
 !missing-null-allowed! 'UIKit.UIViewController GameKit.GKScore::ChallengeComposeController(System.String[],System.String,GameKit.GKChallengeComposeHandler)' is missing an [NullAllowed] on return type
+!missing-null-allowed! 'System.String GameKit.GKAchievement::get_PlayerID()' is missing an [NullAllowed] on return type
+!missing-null-allowed! 'System.String[] GameKit.GKMatch::get_PlayersIDs()' is missing an [NullAllowed] on return type
+!missing-null-allowed! 'System.String[] GameKit.GKVoiceChat::get_PlayerIDs()' is missing an [NullAllowed] on return type


please add them :)
that will make it easier to complete nullability support (at some point) if all new API already have them

spouliot · 2020-07-17T19:09:55Z

tests/xtro-sharpie/macOS-GameKit.ignore

@@ -45,3 +45,5 @@
 !missing-null-allowed! 'System.Void GameKit.GKDialogController::set_ParentWindow(AppKit.NSWindow)' is missing an [NullAllowed] on parameter #0
 !missing-null-allowed! 'System.Void GameKit.GKGameSession::SendMessage(System.String,System.String[],Foundation.NSData,GameKit.GKCloudPlayer[],System.Boolean,System.Action`1<Foundation.NSError>)' is missing an [NullAllowed] on parameter #2
 !missing-null-allowed! 'System.Void GameKit.GKMatchmakerViewController::set_DefaultInvitationMessage(System.String)' is missing an [NullAllowed] on parameter #0
+!missing-null-allowed! 'System.String[] GameKit.GKMatch::get_PlayersIDs()' is missing an [NullAllowed] on return type
+!missing-null-allowed! 'System.String[] GameKit.GKVoiceChat::get_PlayerIDs()' is missing an [NullAllowed] on return type


src/gamekit.cs

spouliot · 2020-07-17T19:18:13Z

src/gamekit.cs

+
+		[TV (14, 0), NoWatch, Mac (10, 16), iOS (14, 0)]
+		[Field ("GKPlayerIDNoLongerAvailable")]
+		NSString GKPlayerIdNoLongerAvailable { get; }


we normally remove the prefix on fields, e.g. IdNoLongerAvailable when inside the type GKPlayer

spouliot · 2020-07-17T19:19:28Z

src/gamekit.cs

@@ -803,6 +939,11 @@ interface GKLocalPlayer
 		[Static]
 		[Export ("local")]
 		GKLocalPlayer Local { get; }
+
+		[NoWatch]
+		[TV (14,0), NoWatch, Mac (10,16), iOS (14,0)]


NoWatch twice present

src/gamekit.cs

spouliot · 2020-07-17T19:22:58Z

src/gamekit.cs

+		[Export ("active")]
+		bool Active { [Bind ("isActive")] get; set; }
+
+		[TV (14,0), NoMac, NoiOS]


no need for [TV (14,0)] since it's already on the type itself

monojenkins · 2020-07-18T00:31:35Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

10 tests failed, 83 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)
introspection/iOS Unified 32-bits - simulator/Debug: Failed
introspection/iOS Unified 32-bits - simulator/Debug (iOS 10.3): Failed
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed
introspection/tvOS - simulator/Debug (tvOS 10.2): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed

src/GameKit/GKLeaderboardSet.cs

src/GameKit/GameKit.cs

src/gamekit.cs

monojenkins · 2020-07-20T16:12:01Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

monojenkins · 2020-07-20T16:36:52Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

monojenkins · 2020-07-20T16:50:13Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

spouliot · 2020-07-20T18:28:17Z

src/gamekit.cs

+		[Deprecated (PlatformName.iOS, 14, 0, message: "Use 'LoadEntries' to obtain the size of the leaderboard.")]
+		[Deprecated (PlatformName.TvOS, 14, 0, message: "Use 'LoadEntries' to obtain the size of the leaderboard.")]
+		[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'LoadEntries' to obtain the size of the leaderboard.")]
+		[Deprecated (PlatformName.WatchOS, 7, 0, message: "Use 'LoadEntries' to obtain the size of the leaderboard.")]


better share the existing string "Use 'LoadEntries' instead."

spouliot · 2020-07-20T18:28:25Z

src/gamekit.cs

+		[Deprecated (PlatformName.iOS, 14, 0, message: "Use 'LoadEntries' to obtain scores instead.")]
+		[Deprecated (PlatformName.TvOS, 14, 0, message: "Use 'LoadEntries' to obtain scores instead.")]
+		[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'LoadEntries' to obtain scores instead.")]
+		[Deprecated (PlatformName.WatchOS, 7, 0, message: "Use 'LoadEntries' to obtain scores instead.")]


spouliot · 2020-07-20T18:30:17Z

src/gamekit.cs

-		[NoTV]
+		[Deprecated (PlatformName.iOS, 14, 0, message: "Use 'initWithState' instead")]
+		[Deprecated (PlatformName.TvOS, 14, 0, message: "Use 'initWithState' instead")]
+		[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'initWithState' instead")]


that looks like a selector and not the managed name

also messages should end with .

spouliot · 2020-07-20T18:30:45Z

src/gamekit.cs

-		[iOS (7,0)][Mac (10,10)] // Marked 10.9 in header, apple 17612948
+		[Deprecated (PlatformName.iOS, 14, 0, message: "Use 'initWithLeaderboard' instead.")]
+		[Deprecated (PlatformName.TvOS, 14, 0, message: "Use 'initWithLeaderboard' instead.")]
+		[Deprecated (PlatformName.MacOSX, 10, 16, message: "Use 'initWithLeaderboard' instead.")]


same, selector vs managed name

src/gamekit.cs

monojenkins · 2020-07-20T18:52:17Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

9 tests failed, 84 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)
introspection/iOS Unified 32-bits - simulator/Debug: Failed
introspection/iOS Unified 32-bits - simulator/Debug (iOS 10.3): Failed
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed
introspection/tvOS - simulator/Debug (tvOS 10.2): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed

dalexsoto

After @spouliot comments are addressed 👍

monojenkins · 2020-07-20T22:31:11Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

monojenkins · 2020-07-21T00:16:43Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

8 tests failed, 85 tests passed.

Failed tests

introspection/iOS Unified 32-bits - simulator/Debug: Failed
introspection/iOS Unified 32-bits - simulator/Debug (iOS 10.3): Failed
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 10.3): Failed
introspection/tvOS - simulator/Debug (tvOS 10.2): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed

monojenkins · 2020-07-21T23:09:52Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 91 tests passed.

Failed tests

introspection/tvOS - simulator/Debug (tvOS 10.2): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed

monojenkins · 2020-07-23T23:39:25Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

…oards APIs

monojenkins · 2020-07-25T00:09:01Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

whitneyschmidt added this to the xcode12 milestone Jul 17, 2020

whitneyschmidt requested a review from spouliot as a code owner July 17, 2020 18:51

whitneyschmidt requested review from dalexsoto, rolfbjarne and chamons July 17, 2020 18:52

spouliot suggested changes Jul 17, 2020

View reviewed changes

rolfbjarne requested changes Jul 20, 2020

View reviewed changes

spouliot suggested changes Jul 20, 2020

View reviewed changes

dalexsoto approved these changes Jul 20, 2020

View reviewed changes

rolfbjarne approved these changes Jul 21, 2020

View reviewed changes

spouliot approved these changes Jul 21, 2020

View reviewed changes

whitneyschmidt added 10 commits July 24, 2020 12:42

initial gamekit commit for xcode12

7fbfa91

remove extra text

b165876

feedback fixes round 1

2e3789b

remote version check for GKLeaderboardSet::LoadLeaderboards

4e94a23

remove GKLeaderboardSet.cs from frameworks.sources

51bc328

remove [Async] to fix error BI1077

673031b

fix seb round 2 feedback

516b46c

add deprecated back in now that we are exposing new + old LoadLeaderb…

1ed5736

…oards APIs

mark missing API, add async

9e5384c

fix availability for intro

6c992b1

10.16 -> 11.0

117eba0

whitneyschmidt force-pushed the newer_GameKit_xcode12 branch from 37ec2d3 to 117eba0 Compare July 24, 2020 18:13

whitneyschmidt merged commit 0e4749c into xamarin:xcode12 Jul 27, 2020

whitneyschmidt added iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac note-highlight Worth calling out specifically in release notes labels Sep 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Xcode12][GameKit] Update for beta 1-2 #9126

[Xcode12][GameKit] Update for beta 1-2 #9126

whitneyschmidt commented Jul 17, 2020

spouliot Jul 17, 2020

spouliot Jul 17, 2020

spouliot Jul 17, 2020

whitneyschmidt Jul 17, 2020

spouliot Jul 17, 2020

whitneyschmidt Jul 17, 2020

spouliot Jul 17, 2020

spouliot Jul 17, 2020

spouliot Jul 17, 2020

spouliot Jul 17, 2020

spouliot Jul 17, 2020

monojenkins commented Jul 18, 2020

Failed tests

monojenkins commented Jul 20, 2020

monojenkins commented Jul 20, 2020

monojenkins commented Jul 20, 2020

spouliot Jul 20, 2020

spouliot Jul 20, 2020

spouliot Jul 20, 2020

spouliot Jul 20, 2020

spouliot Jul 20, 2020

monojenkins commented Jul 20, 2020

Failed tests

dalexsoto left a comment

monojenkins commented Jul 20, 2020

monojenkins commented Jul 21, 2020

Failed tests

monojenkins commented Jul 21, 2020

Failed tests

monojenkins commented Jul 23, 2020

monojenkins commented Jul 25, 2020

[Xcode12][GameKit] Update for beta 1-2 #9126

[Xcode12][GameKit] Update for beta 1-2 #9126

Conversation

whitneyschmidt commented Jul 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jul 18, 2020

Test results

Failed tests

monojenkins commented Jul 20, 2020

monojenkins commented Jul 20, 2020

monojenkins commented Jul 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jul 20, 2020

Test results

Failed tests

dalexsoto left a comment

Choose a reason for hiding this comment

monojenkins commented Jul 20, 2020

monojenkins commented Jul 21, 2020

Test results

Failed tests

monojenkins commented Jul 21, 2020

Test results

Failed tests

monojenkins commented Jul 23, 2020

monojenkins commented Jul 25, 2020