[CoreVideo][Xcode12] Update through beta 3 #9209
Conversation
src/CoreVideo/CVPixelFormatType.cs
Outdated
| OneComponent16 = 0x4c303136, // 'L016' | ||
| TwoComponent16 = 0x32433136, // '2C16' | ||
| CV16VersatileBayer = 0x62703136, // 'bp16' | ||
| CV64RGBA_DownscaledProResRAW = 0x62703634, // 'bp64' |
src/CoreVideo/CVPixelFormatType.cs
Outdated
| @@ -5,6 +5,7 @@ | |||
| // | |||
| // Copyright 2011 Novell, Inc | |||
| // Copyright 2011-2014, 2016 Xamarin Inc | |||
| // Copyright 2020 Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
I have to look up but it's not the right copyright - at least the All rights reserved. part
There was a problem hiding this comment.
I'll check our other files!
There was a problem hiding this comment.
I'm seeing a lot of files where w/o the All rights reserved....I'll remove it and leave the Microsoft Corp part 👍
src/corevideo.cs
Outdated
| @@ -426,6 +431,55 @@ interface CVPixelBuffer { | |||
| [Field ("kCVPixelBufferOpenGLTextureCacheCompatibilityKey")] | |||
| NSString OpenGLTextureCacheCompatibilityKey { get; } | |||
| #endif | |||
| [Unavailable (PlatformName.MacCatalyst)] | |||
| [NoWatch, NoTV, NoMac, iOS (14, 0)] | |||
| [Field ("kCVPixelBufferProResRAWKey_BlackLevel"), Advice ("This API is not available when using MacCatalyst.")] | |||
There was a problem hiding this comment.
minor/style: having [Advice] and [Field] on the same line is more likely to be harder to review in the future
e.g. the advice might be be tru next year, if catalyst support is added, and someone could miss a typo in the field name (but intro should spot it)
They can be on different lines or you can combine the catalyst ones together, since they will be updated together.
[Unavailable (PlatformName.MacCatalyst), Advice ("This API is not available when using MacCatalyst.")]]
[Field ("kCVPixelBufferProResRAWKey_BlackLevel")]
|
Build failure |
|
Build success |
whitneyschmidt
added
iOS
No description provided.