[CoreMedia] Update bindings to Xcode 12 Beta 4 #9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexsoto
added
the
note-highlight
mandel-macaque
approved these changes
Aug 6, 2020
whitneyschmidt
approved these changes
Aug 6, 2020
| @@ -244,6 +244,8 @@ public enum CMVideoCodecType : uint | |||
| Mpeg4Video = 0x6d703476, | |||
| Mpeg2Video = 0x6d703276, | |||
| Mpeg1Video = 0x6d703176, | |||
| [iOS (14,0), TV (14,0), Watch (7,0), Mac (11,0)] | |||
There was a problem hiding this comment.
Correct me if I'm getting this wrong for this case! Don't we usually add the newest enums at the end of the list?
There was a problem hiding this comment.
You can but since these enums have an explicit value you can put them wherever you want, I like to keep the same order as their native counterpart so it is easier to compare whenever you come back to them.
rolfbjarne
approved these changes
Aug 6, 2020
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.