Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapKit] Update the framework to Xcode 12 beta 4. #9314

Merged
merged 6 commits into from
Aug 10, 2020

Conversation

mandel-macaque
Copy link
Member

No description provided.

src/mapkit.cs Outdated
Comment on lines 1746 to 1747
[Export ("locations", ArgumentSemantic.Copy)]
NSNumber[] Locations { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BindAs?

src/mapkit.cs Outdated
UIColor[] Colors { get; }

[Export ("setColors:atLocations:")]
void SetColors (UIColor[] colors, NSNumber[] locations);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BindAs?

src/mapkit.cs Outdated Show resolved Hide resolved
src/mapkit.cs Outdated Show resolved Hide resolved
src/mapkit.cs Outdated Show resolved Hide resolved
@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: Failed (Test run failed.)

mandel-macaque and others added 2 commits August 7, 2020 10:41
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@dalexsoto dalexsoto added the note-highlight Worth calling out specifically in release notes label Aug 7, 2020
@dalexsoto dalexsoto added this to the xcode12 milestone Aug 7, 2020
@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: Failed (Test run failed.)

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@mandel-macaque mandel-macaque merged commit 9405c5e into xamarin:xcode12 Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants