Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMP for the repeated-moment algorithm #46

Closed
nquesada opened this issue Sep 13, 2019 · 3 comments
Closed

OpenMP for the repeated-moment algorithm #46

nquesada opened this issue Sep 13, 2019 · 3 comments
Assignees
@trevor-vincent
Labels
C++ enhancement New feature or request

Comments

@nquesada
Copy link
Collaborator

Currently only the recursive and eigenvalue-trace algorithm support OpenMP. It would be good to add multi thread capabilities in the repeated-moment algorithm. This might be non trivial due to possible race conditions created by the break statement in line 199 of https://github.com/XanaduAI/thewalrus/blob/master/include/repeated_hafnian.hpp .
@nquesada nquesada added enhancement New feature or request C++ labels Sep 13, 2019
@nquesada
Copy link
Collaborator Author

Note that to improve accuracy this algorithm can either use fsum or be done in quad precision.

@trevor-vincent
Copy link
Contributor

Okay noted, rewriting it this weekend.

@trevor-vincent trevor-vincent mentioned this issue Jan 13, 2020
Merged
@nquesada
Copy link
Collaborator Author

nquesada commented Jan 18, 2020 •
edited

Solved in #120 . Great work @trevor-vincent .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevor-vincent trevor-vincent

Labels
C++ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nquesada @trevor-vincent