Skip to content

Commit

Permalink
netrom: Fix a data-race around sysctl_netrom_link_fails_count
Browse files Browse the repository at this point in the history
[ Upstream commit bc76645 ]

We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
JasonXing authored and Sasha Levin committed Mar 15, 2024
1 parent 859175d commit 0b8eb36
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netrom/nr_route.c
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ void nr_link_failed(ax25_cb *ax25, int reason)
nr_neigh->ax25 = NULL;
ax25_cb_put(ax25);

if (++nr_neigh->failed < sysctl_netrom_link_fails_count) {
if (++nr_neigh->failed < READ_ONCE(sysctl_netrom_link_fails_count)) {
nr_neigh_put(nr_neigh);
return;
}
Expand Down

0 comments on commit 0b8eb36

Please sign in to comment.