Skip to content

Commit

Permalink
ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
Browse files Browse the repository at this point in the history
[ Upstream commit 632062e ]

After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
Add missing pwm-supply for regulator-vcck regulator node.

[    7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[    7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[    7.117184] VCCK: supplied by regulator-dummy
[    7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[    7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[    7.118498] VDDEE: will resolve supply early: pwm
[    7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[    7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[    7.118553] VDDEE: supplied by regulator-dummy
[    7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT

Fixes: dee51cd ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
Fixes: d94f60e ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")

Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20210705112358.3554-3-linux.amoon@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
moonlinux authored and gregkh committed Sep 15, 2021
1 parent 0d40e59 commit 2e68547
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion arch/arm/boot/dts/meson8b-mxq.dts
Expand Up @@ -39,6 +39,8 @@
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;

pwm-supply = <&vcc_5v>;

pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;

Expand Down Expand Up @@ -84,7 +86,7 @@
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;

vin-supply = <&vcc_5v>;
pwm-supply = <&vcc_5v>;

pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
Expand Down

0 comments on commit 2e68547

Please sign in to comment.