Skip to content

Commit

Permalink
USB: gadget: lpc32xx_udc: fix memory leak with using debugfs_lookup()
Browse files Browse the repository at this point in the history
[ Upstream commit e3965ac ]

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Jakob Koschel <jakobkoschel@gmail.com>
Cc: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Link: https://lore.kernel.org/r/20230202153235.2412790-10-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
gregkh committed Mar 11, 2023
1 parent f30c704 commit 72c25eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/gadget/udc/lpc32xx_udc.c
Expand Up @@ -532,7 +532,7 @@ static void create_debug_file(struct lpc32xx_udc *udc)

static void remove_debug_file(struct lpc32xx_udc *udc)
{
debugfs_remove(debugfs_lookup(debug_filename, NULL));
debugfs_lookup_and_remove(debug_filename, NULL);
}

#else
Expand Down

0 comments on commit 72c25eb

Please sign in to comment.