Skip to content

Commit

Permalink
usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc
Browse files Browse the repository at this point in the history
[ Upstream commit ce9daa2 ]

We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Ma Ke authored and gregkh committed Sep 23, 2023
1 parent bbc9c36 commit 826e9c9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/usb/gadget/udc/fsl_qe_udc.c
Expand Up @@ -1959,9 +1959,13 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value,
} else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) {
/* Get endpoint status */
int pipe = index & USB_ENDPOINT_NUMBER_MASK;
struct qe_ep *target_ep = &udc->eps[pipe];
struct qe_ep *target_ep;
u16 usep;

if (pipe >= USB_MAX_ENDPOINTS)
goto stall;
target_ep = &udc->eps[pipe];

/* stall if endpoint doesn't exist */
if (!target_ep->ep.desc)
goto stall;
Expand Down

0 comments on commit 826e9c9

Please sign in to comment.