Skip to content

Commit

Permalink
arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 …
Browse files Browse the repository at this point in the history
…Puma

commit 0ac417b upstream.

Q7_THRM# pin is connected to a diode on the module which is used
as a level shifter, and the pin have a pull-down enabled by
default. We need to configure it to internal pull-up, other-
wise whenever the pin is configured as INPUT and we try to
control it externally the value will always remain zero.

Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com>
Fixes: 2c66fc3 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240308085243.69903-1-iskander.amara@theobroma-systems.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Iskander Amara authored and gregkh committed May 2, 2024
1 parent e64c811 commit 9b338b2
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,16 @@
};

&pinctrl {
pinctrl-names = "default";
pinctrl-0 = <&q7_thermal_pin>;

gpios {
q7_thermal_pin: q7-thermal-pin {
rockchip,pins =
<0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
};
};

i2c8 {
i2c8_xfer_a: i2c8-xfer {
rockchip,pins =
Expand Down

0 comments on commit 9b338b2

Please sign in to comment.