Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required_approval_count for protected_environments #1482

Merged
merged 5 commits into from Jun 7, 2022

Conversation

thenom
Copy link
Contributor

@thenom thenom commented May 23, 2022

Setup to allow control over the protected environments required approval counts.

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other then a small ordering request. If you update that I'll go ahead and merge this one...

protected_environments.go Show resolved Hide resolved
protected_environments.go Outdated Show resolved Hide resolved
protected_environments_test.go Outdated Show resolved Hide resolved
protected_environments_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thenom! LGTM 👍🏻

@svanharmelen svanharmelen force-pushed the feature/required-approval-count branch from 02b7c55 to ed06238 Compare June 7, 2022 08:09
@svanharmelen svanharmelen merged commit 86c4f8d into xanzy:master Jun 7, 2022
@thenom thenom deleted the feature/required-approval-count branch June 7, 2022 08:55
@timofurrer
Copy link
Contributor

@svanharmelen would you mind releasing so that we have this feature available?

We require it for:

@svanharmelen
Copy link
Member

Done.. v0.68.2

@timofurrer
Copy link
Contributor

Thanks 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants