Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for required_approval_count in gitlab_project_protected_environment #1097

Merged
merged 1 commit into from Jun 26, 2022

Conversation

thenom
Copy link
Contributor

@thenom thenom commented May 23, 2022

Description

Issue Add protected environments required_approval_count
https://github.com/gitlabhq/terraform-provider-gitlab/issues/1096

This is the PR for the dependency package:
xanzy/go-gitlab#1482

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

@github-actions github-actions bot added provider resource Adds or modifies a resource tests size/S labels May 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @thenom 👋

It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the community! 😃

@thenom
Copy link
Contributor Author

thenom commented Jun 7, 2022

xanzy/go-gitlab#1482

This has been merged, just waiting for a tag to continue with this.

@timofurrer timofurrer marked this pull request as ready for review June 25, 2022 14:48
@timofurrer timofurrer added this to the v3.16.0 milestone Jun 25, 2022
@timofurrer timofurrer self-assigned this Jun 25, 2022
timofurrer
timofurrer previously approved these changes Jun 25, 2022
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty and made it ready for a merge.

🚢

@timofurrer timofurrer merged commit 40a06bf into gitlabhq:main Jun 26, 2022
@timofurrer timofurrer linked an issue Jun 26, 2022 that may be closed by this pull request
1 task
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This functionality has been released in v3.16.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants