Change Build Triggers to PipelinTriggers. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2017 15:02
See documentation for expected return statuses: https://docs.gitlab.com/ce/api/README.html#status-codes Also change the codes to http library codes.
This is in line with the updated v4 API. See https://docs.gitlab.com/ce/api/pipeline_triggers.html and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9713 for more information.
|
All changed functions tested against a v4 GitLab API. |
|
@johanbrandhorst the code looks fine, but I would suggest creating a dedicated service for the PipelineTriggers ( FYI I try to follow (more or less) the segmentation Gitlab uses to describe different parts of the API: https://docs.gitlab.com/ce/api/README.html#resources |
|
OK I will update it. I thought since it was under |
|
That also makes sense, I just choose to follow the docs and by that also limit the file sizes a bit. Thanks! |
Creates the new service PipelineTriggersService for handling requests to the Pipeline Triggers part of the GitLab API.
|
Looks great! Thanks 👍 |
svanharmelen
pushed a commit
that referenced
this pull request
Aug 25, 2017
* Add StatusNoContent as successful status. See documentation for expected return statuses: https://docs.gitlab.com/ce/api/README.html#status-codes Also change the codes to http library codes. * Change Build Triggers to PipelinTriggers. This is in line with the updated v4 API. See https://docs.gitlab.com/ce/api/pipeline_triggers.html and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9713 for more information. * Move Pipeline Triggers to a separate file. Creates the new service PipelineTriggersService for handling requests to the Pipeline Triggers part of the GitLab API.
svanharmelen
pushed a commit
that referenced
this pull request
Aug 25, 2017
* Add StatusNoContent as successful status. See documentation for expected return statuses: https://docs.gitlab.com/ce/api/README.html#status-codes Also change the codes to http library codes. * Change Build Triggers to PipelinTriggers. This is in line with the updated v4 API. See https://docs.gitlab.com/ce/api/pipeline_triggers.html and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9713 for more information. * Move Pipeline Triggers to a separate file. Creates the new service PipelineTriggersService for handling requests to the Pipeline Triggers part of the GitLab API.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with the updated v4 API. See https://docs.gitlab.com/ce/api/pipeline_triggers.html and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9713 for more information.
Also add StatusNoContent as successful status and update hardcoded status codes to
http.Status*codes.