Return basic info about pipeline in GET /projects/:id/pipelines #163
Conversation
examples/pipelines.go
Outdated
| git.SetBaseURL("https://gitlab.com/api/v4") | ||
|
|
||
| pipelines, _, err := git.Pipelines.ListProjectPipelines(2743054) | ||
|
|
There was a problem hiding this comment.
nitting please remove this empty line here
| Ref string `json:"ref"` | ||
| Sha string `json:"sha"` | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure what to make of this. I see what you are trying to do and I agree it's maybe somewhat cleaner to have a smaller struct matching the field returned from a list call. But I don't think I like the suggested solution.
The name RootPipeline seems to imply something that doesn't exist (there is no such thing as a root of a pipeline). And also please do not put the new type in between the Pipeline type and it's String method. I like to keep those close together. Additionally please also add the String method for the new struct.
As for a possible solution I would like to suggest making a PipelineList type:
type PipelineList []struct {
ID int `json:"id"`
Status string `json:"status"`
Ref string `json:"ref"`
Sha string `json:"sha"`
}I think that would (both in term of it's name and it's structure) fit the context a bit better. Thoughts?
|
@ivaravko that looks much better (to me at least 😉) Thanks! |
* Return basic info about pipeline in GET /projects/:id/pipelines * Adds pipeline example * Rename RootPipeline to PipelineList with type []struct
* Return basic info about pipeline in GET /projects/:id/pipelines * Adds pipeline example * Rename RootPipeline to PipelineList with type []struct
This is updated v4 API. See https://docs.gitlab.com/ce/api/pipelines.html#list-project-pipelines and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8875 for more information.