Not defining tags attribute should not trigger change

[landro]

Terraform Version

Run terraform -v to show the version. If you are not running the latest version of Terraform, please upgrade because your issue may have already been fixed.

➜ digi_opstest git:(master) terraform --version
Terraform v0.11.1

• provider.aws v1.6.0
• provider.cloudstack v0.1.2

Affected Resource(s)

Please list the resources as a list, for example:

• cloudstack_instance and all others that have tag support it appears

Terraform Configuration Files

resource "cloudstack_instance" "ssh" {
  name             = "whatever"
  service_offering = "whatever"
  network_id       = "whatever"
  template         = "whatever"
  zone             = "whatever"

  #tags = {
  #  
  #}

}

Debug Output

~ cloudstack_instance.ssh
tags.%: "" =>

Expected Behavior

Upgrading terraform provider version to 0.1.2 on existing infrastructure should not trigger change for optional tags attribute

Actual Behavior

Running apply without defining tags, triggers change. Even after aplying change, rerunning plan/apply will trigger change.

[svanharmelen]

Hi @landro,

Thanks for the report! The problem should be fixed in master now. I'll poke our HashiCorp friends to see if we can create a new release to fix this problem...

Cheers!

[svanharmelen]

@landro a new build is currently being released, so you can update and retry in a bit...

[landro]

Thanks! Great stuff. I’ll give it a shot tomorrow!

…

20. des. 2017 kl. 16:42 skrev Sander van Harmelen ***@***.***>: @landro a new build is currently being released, so you can update and retry in a bit... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[landro]

works like a charm! Thanks again, @svanharmelen !

[landro]

Just ran in to a related issue this afternoon using the new version of the provider.
CloudStack API error 431 (CSExceptionErrorCode: 9999): Unable to execute API command createtags due to missing parameter tags.
Issue occured when I tainted an existing instance that didnt't have tags, and recreated it.

[svanharmelen]

Hmm... Thanks, I’ll have a look later today...

[svanharmelen]

@landro the problem was a bad check to determine if tags should be set. This is not fixed in PR #29...

[svanharmelen]

@landro version 0.1.4 containing this fix is just released, so it should be available for download...

[landro]

Have been using 0.1.4 for a few days now. Works as expected! Thanks!

[svanharmelen]

Glad to hear that. Thanks for the update @landro