CP-5946 #53
Closed
CP-5946 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sleep hack was originally introduced to work around a failure around xc_evtchn_bind_interdomain. With the new 3.x kernel, I couldn't reproduce the failure with this hack commented out. I tried iterations of tests on a few different setups on different hardware, the result seems persistent. So I'd propose to remove the hack, and hopefully it should just work. We can investigate further if any new problem is spot later. Signed-off-by: Zheng Li <zheng.li@eu.citrix.com>
ghost
assigned
zli
added a commit
that referenced
this pull request
Sep 16, 2013
The sleep hack was originally introduced to work around a failure around xc_evtchn_bind_interdomain. With the new 3.x kernel, I couldn't reproduce the failure with this hack commented out. I tried iterations of tests on a few different setups on different hardware, the result seems persistent. So I'd propose to remove the hack, and hopefully it should just work. We can investigate further if any new problem is spot later. Signed-off-by: Zheng Li <zheng.li@eu.citrix.com> Reviewed-by: Thanos Makatos <thanos.makatos@citrix.com> Github: close #53 on xapi-project/blktap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.