Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from jbuilder to dune. #2

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Dec 7, 2018

Signed-off-by: Konstantina Chremmou konstantina.chremmou@citrix.com

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Copy link
Collaborator

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I think we can also avoid the echo () workaround and use dune's builtin pkg-config support (albeit at the cost of slightly more boilerplate).

lib_gen/types/dune Show resolved Hide resolved
@edwintorok edwintorok merged commit 1541b42 into xapi-project:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants