CP-11979: Added FCoE driver and fixed sr-probe. #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pritha-srivastava is this PR complete? I don't see changes to Makefile etc to include this driver in the RPM. |
|
I think the Makefile has been missed. I'll re-submit the PR. |
|
@pritha-srivastava , could we please refresh this PR? |
pritha-srivastava
force-pushed
the
CP-11979
branch
from
562c5d3
to
414f379
Compare
|
@chandrikas : I've added the Makefiles to the pull request. This is the first one in the series of patches for FCoE (which has been already reviewed by you earlier). I'll create pull requests for ones that are dependant on this once this gets accepted. Let me know if I need to do something else |
Signed-off-by: Pritha Srivastava <pritha.srivastava@citrix.com>
pritha-srivastava
force-pushed
the
CP-11979
branch
from
414f379
to
282c0b5
Compare
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pritha Srivastava pritha.srivastava@citrix.com