Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-286144: add usb-scan systemd units #412

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

srowe
Copy link
Contributor

@srowe srowe commented Nov 5, 2018

udev does not tolerate the time it can take for XAPI to complete a
pUSB rescan request. Use a service listening on a socket to perform
the scan request so that the udev action just becomes writing to a
non-blocking pipe.

udev does not tolerate the time it can take for XAPI to complete a
pUSB rescan request. Use a service listening on a socket to perform
the scan request so that the udev action just becomes writing to a
non-blocking pipe.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 33.603% when pulling f64dd9d on srowe:usb_change into 26096a2 on xapi-project:master.

Copy link
Contributor

@MarkSymsCtx MarkSymsCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TimSmithCtx TimSmithCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

I think we want to add conv=nocreat to the kicker, but that can be done generalising this to use it for the multipath scan.

@MarkSymsCtx MarkSymsCtx merged commit 8af9165 into xapi-project:master Nov 5, 2018
@srowe
Copy link
Contributor Author

srowe commented Nov 5, 2018

This needs spec files changes to add and activate the new units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants