CP-6337: Remove explicit mapping patch in multipath and move it into sm #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -51,8 +51,8 @@ def resize_map(m): | |||
| mpexec("resize map %s" % m) | |||
|
|
|||
| # Don't reconfigure!! | |||
There was a problem hiding this comment.
No :(
I left it by mistake
|
|
Looks good - ship it! |
This script is a basic multipath.conf to add and remove WWIDs in the blacklist_exceptions section Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
This patch ensure the new mechanism for explicit multipath mapping is active. The corresponding patch in dm-multipath can be removed. Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
Once started the multipath daemon does not load the needed kernel modules. In the past it was not a problem because they are loaded as soon as a device is added using the CLI. Now we need some checks before doing this and they fail if this modules are not loaded. Loading modules while starting multipath is the standard behaviour in more recent versions of multipath. We just ensure this is always true. Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
| # but we do not care about it. | ||
| if len(stdout) != 0: | ||
| rc = 0 | ||
| return rc != False |
There was a problem hiding this comment.
I replaced "rc and True or False" with this. Is it more readable?
andrey-podko
referenced
this pull request
in andrey-podko/sm
Aug 16, 2022
GitHub: closes xcp-ng#54 on xapi-project/sm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are surely 2 things to be addressed: