CA-115035: mpath-boot and multipathed host other-config keys missing #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before upgrading to the new kernel, the output of multipath -k"show maps" and echo "show maps" |multipathd -k were different. Now they are the same but previous code in mpathcount.py was relying exclusively on the wrong output in the previous version. Now it is fixed in both cases Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
ghost
assigned 
| @@ -223,6 +223,9 @@ def _add(key, val): | |||
| session.xenapi.host.add_to_other_config(localhost,key,val) | |||
| config = session.xenapi.host.get_other_config(localhost) | |||
| maps = mpath_cli.list_maps() | |||
| # Ensure output headers are not in the list | |||
| if 'name' in maps: | |||
| maps.remove('name') | |||
There was a problem hiding this comment.
Not very comfortable hard-coding the "name" string for parsing. Is there another way to get around this problem?
There was a problem hiding this comment.
Since it doesn't really break anything else at the moment, let's go ahead with this. Could we please put a note in the code to revisit the problem?
There was a problem hiding this comment.
Do you think that putting "memo" in the code will help?
There was a problem hiding this comment.
Let's check this in as is. We can create a follow-up ticket to find a better way (if any)
andrey-podko
referenced
this pull request
in andrey-podko/sm
Aug 16, 2022
Before upgrading to the new kernel, the output of multipath -k"show maps" and echo "show maps" |multipathd -k were different. Now they are the same but previous code in mpathcount.py was relying exclusively on the wrong output in the previous version. Now it is fixed in both cases Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xcp-ng#57 on xapi-project/sm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before upgrading to the new kernel, the output of
multipath -k"show maps"
and
echo "show maps" |multipathd -k
were different.
Now they are the same but previous code in mpathcount.py was
relying exclusively on the wrong output in the previous version.
Now it is fixed in both cases
Signed-off-by: Germano Percossi germano.percossi@citrix.com