Replace python example code with minimal functional implementation. #105
Conversation
It's about the smallest amount that can actually be functional, unlike the removed example which didn't actually do anything other than respond to the requests. This example is good enough to install and run VMs on albeit with some limitations. |
python/examples/README.md
Outdated
| https://xapi-project.github.io/xapi-storage/?python#plugin. This | ||
| declares the name of the plugin, version, vendor, copyright etc and | ||
| the capabilities supported by the implementation of the | ||
| plugin. Simpler than the definition for a volume plugin as now |
There was a problem hiding this comment.
Did you mean "no features are exposed"?
There was a problem hiding this comment.
yes, well spotted
MarkSymsCtx
force-pushed
the
update_examples
branch
from
d0ef435
to
00e6d9e
Compare
|
Can we merge this? |
| "VDI_DEACTIVATE", | ||
| "VDI_UPDATE", | ||
| "VDI_RESIZE", | ||
| "SR_METADATA", |
There was a problem hiding this comment.
I'm not sure about the exact meaning of this, but it looks like this is needed only if the SR supports disaster recovery. SInce this example SR doesn't even support set_name or set_description I think we could safely remove this particular feature.
There was a problem hiding this comment.
Yes, very true.
|
Looks good, one minor comment about SR_METADATA |
Signed-off-by: Mark Syms <mark.syms@citrix.com>
MarkSymsCtx
force-pushed
the
update_examples
branch
from
00e6d9e
to
d91941c
Compare
|
Can we merge this? |
Signed-off-by: Mark Syms mark.syms@citrix.com