Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced jbuild files with dune. #97

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Jan 31, 2019

Please note that make test fails, but this is not caused by this PR (needs to be updated to use the latest interface from rpclib).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@edwintorok
Copy link
Contributor

Could you open a ticket about the unit test failure?

@lindig
Copy link
Contributor

lindig commented Jan 31, 2019

I see this in the Travis build. The build succeeds and this is the part of the test that fails:

 File "generator/test/storage_test.ml", line 70, characters 17-28:
- Error: Unbound module type Idl.RPCfunc
[ERROR] The compilation of xapi-storage failed at "/home/opam/.opam/4.07/bin/dune runtest -p xapi-storage -j 127".

@kc284
Copy link
Contributor Author

kc284 commented Jan 31, 2019

Indeed; this module type and others were removed from the rpclib, but neither the README in rpclib was updated nor the tests here.

@lindig
Copy link
Contributor

lindig commented Jan 31, 2019

I don't understand why this has not lead to failures of xs-opam on Travis and I would expect failures if we merge. I think the tests should be disabled in the opam file for now to avoid this.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
@kc284
Copy link
Contributor Author

kc284 commented Jan 31, 2019

The job in xs-opam installs packages but does not seem to run tests. It might be a good idea to run them so as to catch cases like this.

@lindig lindig merged commit 9610ea9 into xapi-project:master Jan 31, 2019
edwintorok added a commit to xapi-project/xs-opam that referenced this pull request Jan 31, 2019
See xapi-project/xapi-storage#97 (comment)
Would be useful to try and run these in Travis if they do not take a long time to run (but of course we'll also have to fix the tests before merging this PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants