-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced jbuild files with dune. #97
Conversation
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Could you open a ticket about the unit test failure? |
I see this in the Travis build. The build succeeds and this is the part of the test that fails:
|
Indeed; this module type and others were removed from the rpclib, but neither the README in rpclib was updated nor the tests here. |
I don't understand why this has not lead to failures of xs-opam on Travis and I would expect failures if we merge. I think the tests should be disabled in the opam file for now to avoid this. |
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The job in xs-opam installs packages but does not seem to run tests. It might be a good idea to run them so as to catch cases like this. |
See xapi-project/xapi-storage#97 (comment) Would be useful to try and run these in Travis if they do not take a long time to run (but of course we'll also have to fix the tests before merging this PR)
Please note that
make test
fails, but this is not caused by this PR (needs to be updated to use the latest interface from rpclib).