coverage: be less smart #199
Conversation
Copy over all the files, include all folders and avoid using arrays. Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
.coverage.sh
Outdated
| # move all bisect files here | ||
| find . -name 'bisect*.out' -exec mv {} . \; | ||
|
|
||
| DIRECTORIES=`find . -type d` |
There was a problem hiding this comment.
This is quite a nice pattern. The printf creates a string "-I xx -I yy -I zz" - one entry per directory.
.coverage.sh
Outdated
| @@ -22,7 +22,7 @@ jbuilder runtest | |||
| # move all bisect files here | |||
| find . -name 'bisect*.out' -exec mv {} . \; | |||
|
|
|||
| DIRECTORIES=`find . -type d` | |||
| DIRECTORIES=$(find _build/default -type d -not -path '*/\.*') | |||
There was a problem hiding this comment.
In '*/\.*' the \ is not required but does no harm.
There was a problem hiding this comment.
I wasn’t sure. Do you want me to remove it?
There was a problem hiding this comment.
Unless you update this PR for something else, this is fine.
| # move all bisect files here | ||
| find . -name 'bisect*.out' -exec mv {} . \; | ||
|
|
||
| DIRECTORIES=$(find _build/default -type d -not -path '*/\.*') |
There was a problem hiding this comment.
Not sure what this is meant to exclude, are there some hidden directories under _build?
There was a problem hiding this comment.
Yes, .ppx with the rewriters. It is not necessary though, just nicer output
|
Aargh I didn't do the squash :( how should we deal with it? Squash and force push locally or keep it like that? |
|
I see no problem keeping this. |
Copy over all the bisect files, include all folders and avoid using arrays.
Signed-off-by: Marcello Seri marcello.seri@citrix.com