-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: be less smart #199
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ jbuilder runtest | |
# move all bisect files here | ||
find . -name 'bisect*.out' -exec mv {} . \; | ||
|
||
DIRECTORIES=`find . -type d` | ||
DIRECTORIES=$(find _build/default -type d -not -path '*/\.*') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what this is meant to exclude, are there some hidden directories under _build? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, .ppx with the rewriters. It is not necessary though, just nicer output |
||
printf -v INCLUDES " -I %s" $DIRECTORIES | ||
|
||
bisect-ppx-report bisect*.out $INCLUDES -text report | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
'*/\.*'
the\
is not required but does no harm.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn’t sure. Do you want me to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you update this PR for something else, this is fine.