Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CLI tools with runtest #201

Merged
merged 4 commits into from
Feb 1, 2018
Merged

Conversation

minishrink
Copy link
Contributor

@minishrink minishrink commented Feb 1, 2018

This PR builds all daemon debugger CLI tools with jbuilder runtest/make test.
It also removes unnecessary PPX rewriter dependencies from cluster/jbuild

Signed-off-by: Akanksha Mathur akanksha.mathur@citrix.com

Akanksha Mathur added 3 commits February 1, 2018 11:55
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
@minishrink
Copy link
Contributor Author

@mseri Will add another commit that adds an alias to build all the CLI tools and updates the README accordingly.

@coveralls
Copy link

Coverage Status

Coverage increased (+15.7%) to 26.706% when pulling 9d77c05 on minishrink:removecamlp4 into 8ab1ac7 on xapi-project:master.

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 11.014% when pulling 9c93782 on minishrink:removecamlp4 into 8ab1ac7 on xapi-project:master.

So uh, that's now a thing.

Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
@mseri
Copy link
Collaborator

mseri commented Feb 1, 2018

Squash the last two commits and update the PR title, then it's good to merge

@minishrink minishrink changed the title Remove unused libraries and build targets from clusterd Build CLI tools with runtest Feb 1, 2018
@mseri mseri merged commit 8713d7c into xapi-project:master Feb 1, 2018
@minishrink minishrink deleted the removecamlp4 branch February 15, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants