Skip to content
This repository has been archived by the owner on May 22, 2018. It is now read-only.

CA-85761: distinguish between unguessable Uuid.ts and Uuid.ts which are merely unique #108

Closed
wants to merge 2 commits into from
Closed

CA-85761: distinguish between unguessable Uuid.ts and Uuid.ts which are merely unique #108

wants to merge 2 commits into from

Conversation

djs55
Copy link
Collaborator

@djs55 djs55 commented Jul 11, 2012

It's expensive to create unguessable Uuid.ts, so we should use them sparingly.

@xen-git
Copy link

xen-git commented Jul 11, 2012

djs55/xen-api-libs@f8b70c6 ⇒ 779ed73: Merge and build failed.

Failed when executing:
make api-build
Error log:
--- Checking for ocamlopt.opt... (found /usr/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
- build ocaml/idl/ocaml_backend ref.o
+ ocamlfind ocamlopt -package stdext,log,xml-light2,stunnel,sexpr,http-svr,rpc-light -g -dtypes -thread -warn-error +a-4-6-9-27-28-29 -ccopt -fPIC -I +ocamldoc -I .. -I ../.. -I ../../database -I ../../autogen -I ../../xapi -I ../../client_records -I ../../util -c ref.ml
File "ref.ml", line 21, characters 34-48:
Error: Unbound value Uuid.make_uuid
*** omake: 243/341 targets are up to date
*** omake: failed (0.77 sec, 30/30 scans, 15/25 rules, 124/426 digests)
*** omake: targets were not rebuilt because of errors:
ocaml/idl/ocaml_backend/ref.cmx
depends on: ocaml/idl/ocaml_backend/ref.ml
ocaml/idl/ocaml_backend/ref.o
depends on: ocaml/idl/ocaml_backend/ref.ml
make[4]: *** [all] Error 2
error: Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.99505 (_build)

RPM build errors:
    Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.99505 (_build)
make[3]: *** [/output/api/cli-regress.tar.gz] Error 1

@xen-git
Copy link

xen-git commented Jul 13, 2012

djs55/xen-api-libs@f8b70c6 ⇒ 3850d18: Merge and build failed.

Failed when executing:
make api-build
Error log:
--- Checking for ocamlopt.opt... (found /usr/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
- build ocaml/idl/ocaml_backend ref.o
+ ocamlfind ocamlopt -package stdext,log,xml-light2,stunnel,sexpr,http-svr,rpc-light -g -dtypes -thread -warn-error +a-4-6-9-27-28-29 -ccopt -fPIC -I +ocamldoc -I .. -I ../.. -I ../../database -I ../../autogen -I ../../xapi -I ../../client_records -I ../../util -c ref.ml
File "ref.ml", line 21, characters 34-48:
Error: Unbound value Uuid.make_uuid
*** omake: 245/341 targets are up to date
*** omake: failed (0.77 sec, 31/31 scans, 14/26 rules, 121/420 digests)
*** omake: targets were not rebuilt because of errors:
ocaml/idl/ocaml_backend/ref.cmx
depends on: ocaml/idl/ocaml_backend/ref.ml
ocaml/idl/ocaml_backend/ref.o
depends on: ocaml/idl/ocaml_backend/ref.ml
make[4]: *** [all] Error 2
error: Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.62733 (_build)

RPM build errors:
    Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.62733 (_build)
make[3]: *** [/output/api/cli-regress.tar.gz] Error 1

@xen-git
Copy link

xen-git commented Jul 16, 2012

djs55/xen-api-libs@f8b70c6 ⇒ 9d2c780: Merge and build failed.

Failed when executing:
make api-build
Error log:
--- Checking for ocamlopt.opt... (found /usr/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
- build ocaml/idl/ocaml_backend ref.o
+ ocamlfind ocamlopt -package stdext,log,xml-light2,stunnel,sexpr,http-svr,rpc-light -g -dtypes -thread -warn-error +a-4-6-9-27-28-29 -ccopt -fPIC -I ../../../ocaml/idl -I +ocamldoc -I .. -I ../.. -I ../../database -I ../../autogen -I ../../xapi -I ../../client_records -I ../../util -c ref.ml
File "ref.ml", line 21, characters 34-48:
Error: Unbound value Uuid.make_uuid
*** omake: 247/350 targets are up to date
*** omake: failed (0.71 sec, 29/29 scans, 13/21 rules, 121/426 digests)
*** omake: targets were not rebuilt because of errors:
ocaml/idl/ocaml_backend/ref.cmx
depends on: ocaml/idl/ocaml_backend/ref.ml
ocaml/idl/ocaml_backend/ref.o
depends on: ocaml/idl/ocaml_backend/ref.ml
make[4]: *** [all] Error 2
error: Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.82200 (_build)

RPM build errors:
    Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.82200 (_build)
make[3]: *** [/output/api/cli-regress.tar.gz] Error 1

@djs55
Copy link
Collaborator Author

djs55 commented Jul 18, 2012

This needs to be merged at the same time as
xapi-project/xen-api#756

David Scott added 2 commits July 18, 2012 11:15
CA-85761: delete unused "cookie" type from Uuid module
06e15e8 
Signed-off-by: David Scott <dave.scott@eu.citrix.com>
CA-85761: distinguish between unguessable UUIDs ("secure") and only u…
2d9c18f 
…nique UUIDs ("insecure")

Whenever we want a UUID which is only unique, but predictable, we use
  Uuid.insecure ()

Whenever we want a UUID which is both unique and unpredictable, we use
  Uuid.secure ()

Mark Uuid.make_uuid as deprecated.

Signed-off-by: David Scott <dave.scott@eu.citrix.com>
@xen-git
Copy link

xen-git commented Jul 18, 2012

djs55/xen-api-libs@2d9c18f ⇒ 9d2c780: Merge and build failed.

Failed when executing:
make api-build
Error log:
--- Checking for ocamlopt.opt... (found /usr/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
- build ocaml/idl/ocaml_backend ref.o
+ ocamlfind ocamlopt -package stdext,log,xml-light2,stunnel,sexpr,http-svr,rpc-light -g -dtypes -thread -warn-error +a-4-6-9-27-28-29 -ccopt -fPIC -I ../../../ocaml/idl -I +ocamldoc -I .. -I ../.. -I ../../database -I ../../autogen -I ../../xapi -I ../../client_records -I ../../util -c ref.ml
File "ref.ml", line 21, characters 34-48:
Error: Unbound value Uuid.make_uuid
*** omake: 248/350 targets are up to date
*** omake: failed (0.75 sec, 29/29 scans, 14/22 rules, 124/432 digests)
*** omake: targets were not rebuilt because of errors:
ocaml/idl/ocaml_backend/ref.cmx
depends on: ocaml/idl/ocaml_backend/ref.ml
ocaml/idl/ocaml_backend/ref.o
depends on: ocaml/idl/ocaml_backend/ref.ml
make[4]: *** [all] Error 2
error: Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.69981 (_build)

RPM build errors:
    Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.69981 (_build)
make[3]: *** [/output/api/cli-regress.tar.gz] Error 1

@xen-git
Copy link

xen-git commented Jul 23, 2012

djs55/xen-api-libs@2d9c18f ⇒ 629b5db: Merge and build failed.

Failed when executing:
make api-build
Error log:
--- Checking for ocamlopt.opt... (found /usr/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
- build ocaml/idl/ocaml_backend ref.o
+ ocamlfind ocamlopt -package stdext,log,xml-light2,stunnel,sexpr,http-svr,rpc-light -g -dtypes -thread -warn-error +a-4-6-9-27-28-29 -ccopt -fPIC -I ../../../ocaml/idl -I +ocamldoc -I .. -I ../.. -I ../../database -I ../../autogen -I ../../xapi -I ../../client_records -I ../../util -c ref.ml
File "ref.ml", line 21, characters 34-48:
Error: Unbound value Uuid.make_uuid
*** omake: 256/353 targets are up to date
*** omake: failed (0.78 sec, 31/31 scans, 14/25 rules, 125/436 digests)
*** omake: targets were not rebuilt because of errors:
ocaml/idl/ocaml_backend/ref.cmx
depends on: ocaml/idl/ocaml_backend/ref.ml
ocaml/idl/ocaml_backend/ref.o
depends on: ocaml/idl/ocaml_backend/ref.ml
make[4]: *** [all] Error 2
error: Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.47204 (_build)

RPM build errors:
    Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.47204 (_build)
make[3]: *** [/output/api/cli-regress.tar.gz] Error 1

@xen-git
Copy link

xen-git commented Nov 20, 2012

djs55/xen-api-libs@2d9c18f ⇒ b17ab35: Merge and build failed.

Failed when executing:
make api-build
Error log:
- build ocaml/idl/ocaml_backend ref.o
+ ocamlfind ocamlopt -package stdext,log,xml-light2,stunnel,sexpr,http-svr,rpc-light -g -dtypes -thread -warn-error +a-4-6-9-27-28-29 -ccopt -fPIC -I ../../../ocaml/idl -I +ocamldoc -I .. -I ../.. -I ../../database -I ../../autogen -I ../../xapi -I ../../client_records -I ../../util -c ref.ml
File "ref.ml", line 21, characters 34-48:
Error: Unbound value Uuid.make_uuid
*** omake: warning: stdout is not a tty, disabling the progress bar
(use --progress to override).
*** omake: 255/350 targets are up to date
*** omake: failed (1.05 sec, 32/32 scans, 15/26 rules, 127/439 digests)
*** omake: targets were not rebuilt because of errors:
ocaml/idl/ocaml_backend/ref.cmx
depends on: ocaml/idl/ocaml_backend/ref.ml
ocaml/idl/ocaml_backend/ref.o
depends on: ocaml/idl/ocaml_backend/ref.ml
make[4]: *** [all] Error 2
error: Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.79536 (_build)

RPM build errors:
    Bad exit status from /obj/RPM_BUILD_DIRECTORY/tmp/rpm-tmp.79536 (_build)
make[3]: *** [/output/api/cli-regress.tar.gz] Error 1

@jonludlam
Copy link
Collaborator

Close this for now - improvements have been made (e.g. only using as much of /dev/urandom as we actually need!)

@jonludlam jonludlam closed this Apr 8, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djs55 @xen-git @jonludlam