Import from url

[jonludlam]

No description provided.

[robhoes]

I find import_from a bit vague... Can we make it something like import_from_url? Or simple import, since we don't actually have that as an API call.

Also, the doc string says URI, but the param has URL.

[djs55]

Yeah, perhaps VM.import since that name is free (as rob says), plus this
API seems quite general.

On Fri, Jun 12, 2015 at 10:52 AM, Rob Hoes notifications@github.com wrote:

In ocaml/idl/datamodel.ml
#2254 (comment):

@@ -2389,6 +2389,19 @@ let vm_call_plugin = call
~allowed_roles:_R_VM_OP
()

+let vm_import_from = call

• ~name:"import_from"
• ~in_product_since:rel_dundee
• ~doc:"Import an XVA from a URI"
• ~params:[String, "url", "The URL of the XVA file";

I find import_from a bit vague... Can we make it something like
import_from_url? Or simple import, since we don't actually have that as
an API call.

Also, the doc string says URI, but the param has URL.

—
Reply to this email directly or view it on GitHub
https://github.com/xapi-project/xen-api/pull/2254/files#r32303426.

Dave Scott

[jonludlam]

Thanks. Yes, import seems reasonable to me. I'll correct the url/uri disparity too, I had changed my mind over which one to call it...

[jonludlam]

to test, try

xe vm-import url=http://xen-git.uk.xensource.com/vagrant/packer-ubuntu-14.10-amd64.xva.gz

[johnelse]

Should import via the CLI fail if the user specifies both url and filename? Other than that, this all looks good to me.

[jonludlam]

Good suggestion, thanks

[johnelse]

!

[jonludlam]

sweet :-)