Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-173622: Enable session.logout() #2259

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Conversation

BobBall
Copy link
Contributor

@BobBall BobBall commented Jun 17, 2015

Several API examples exist, including one in the xen-api repo, that use
session.logout directly without going through session.xenapi or
session.xenapi.session. While this is not the correct way to
logout of the XAPI session, logout is one of the special cases
that needs to be supported from the session object.

Signed-Off-By: Bob Ball bob.ball@citrix.com

Several API examples exist, including one in xen-api, that use
session.logout directly without going through session.xenapi or
session.xenapi.session.  While this is not the correct way to
logout of the XAPI session, logout is one of the special cases
that needs to be supported from the session object.

Signed-Off-By: Bob Ball <bob.ball@citrix.com>
@xen-git
Copy link
Contributor

xen-git commented Jun 17, 2015

Can one of the admins verify this patch for testing?

@simonjbeaumont
Copy link
Contributor

@xen-git test this please.

@jonludlam
Copy link
Contributor

Good to go assuming tests pass

jonludlam pushed a commit that referenced this pull request Jun 17, 2015
CA-173622: Enable session.logout()
@jonludlam jonludlam merged commit 5faf494 into xapi-project:master Jun 17, 2015
@BobBall
Copy link
Contributor Author

BobBall commented Jun 22, 2015

This was commented with the incorrect CA; it should have been CA-173662, not CA-173622.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants