Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backtraces to import.ml #2568

Merged
merged 2 commits into from
Jan 29, 2016
Merged

Add backtraces to import.ml #2568

merged 2 commits into from
Jan 29, 2016

Conversation

johnelse
Copy link
Contributor

No description provided.

@johnelse
Whitespace: import.ml
6b8326c 
$ camlp4o -printer o ocaml/xapi/export.ml | md5sum
8c2f66b37e5f21d083ce7186e8eb7845  -
$ git checkout HEAD^
$ camlp4o -printer o ocaml/xapi/export.ml | md5sum
8c2f66b37e5f21d083ce7186e8eb7845  -

Signed-off-by: John Else <john.else@citrix.com>
@johnelse
Support backtraces in import.ml
1f9402f 
Signed-off-by: John Else <john.else@citrix.com>
@johnelse johnelse added blocked and removed blocked labels Jan 28, 2016
@johnelse
Copy link
Contributor Author

Ran some SXM, DR and import/export tests against this and all is OK, so this is ready for review.

@johnelse
Copy link
Contributor Author

From what I understand of the Backtrace library:

  • Backtrace.is_important e is used when you want to catch e (a "nice" exception), associate the current backtrace with e, and then reraise e after doing some cleanup.
  • Backtrace.reraise old new is used when you want to catch old (typically a non-useful exception like Not_found), and turn it into new (a more useful exception) while reassociating the old backtrace with the new exception.

@robhoes
Copy link
Member

robhoes commented Jan 29, 2016

Ok, sounds good!
:shipit:

@johnelse
Copy link
Contributor Author

👍

johnelse added a commit that referenced this pull request Jan 29, 2016
@johnelse
Merge pull request #2568 from johnelse/import-backtraces
b1972a7 
Add backtraces to import.ml
@johnelse johnelse merged commit b1972a7 into xapi-project:master Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnelse @robhoes