CA-208836 #2641
Merged
CA-208836 #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
…untime Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
If, during VM.create, no value has been supplied for the 'has_vendor_device' field, xapi will fill in 'true' iff the license allows it and the pool.policy_no_vendor_device is false. Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
The CLI will only request a vendor device on vm-install when the recommendations of the template suggest it _and_ there is no policy to disable it. Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
…conditions Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
| field ~qualifier:StaticRO ~lifecycle:[Published, rel_dundee, ""] ~doc_tags:[Windows] ~default_value:(Some (VBool true)) ~ty:Bool "has_vendor_device" "When an HVM guest starts, this controls the presence of the emulated C000 PCI device which triggers Windows Update to fetch or update PV drivers."; | ||
| field ~qualifier:StaticRO ~lifecycle:[Published, rel_dundee, ""] ~doc_tags:[Windows] ~default_value:(Some (VCustom (String.concat "\n" [ | ||
| "(Rpc.Bool ("; | ||
| "let pool = List.hd (Db_actions.DB_Action.Pool.get_all ~__context) in"; |
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
| "(try Rpc.Bool ("; | ||
| "let pool = List.hd (Db_actions.DB_Action.Pool.get_all ~__context) in"; | ||
| "let restrictions = Db_actions.DB_Action.Pool.get_restrictions ~__context ~self:pool in "; | ||
| "let vendor_device_allowed = try List.assoc \"restrict_pci_device_for_auto_update\" restrictions = \"false\" with _ -> false in"; |
There was a problem hiding this comment.
Actually, this would be better: Pool_features.is_enabled ~__context Features.PCI_device_for_auto_update.
There was a problem hiding this comment.
Ah yes, that would be better.
There was a problem hiding this comment.
Ah actually no, I don't have access to the xapi modules, they're not in scope when this is compiled. I think it'll have to be left as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to enable a licensed feature by default.