Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Test_vm_check_operation_error to alcotest #3421

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

gaborigloi
Copy link
Contributor

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 17.685% when pulling 2101c98 on gaborigloi:alcotest_vm_check into 7579faa on xapi-project:master.

@lindig
Copy link
Contributor

lindig commented Jan 31, 2018

Travis passes but does it execute the tests? I wasn't sure when glancing at the logs.

@gaborigloi
Copy link
Contributor Author

It's shown by the opam-coverage build at least: https://travis-ci.org/xapi-project/xen-api/jobs/335218466#L3782
In the main xenserver-build-env build job, we hide the logs: https://github.com/xapi-project/xen-api/blob/master/.travis-xenserver-build-env.sh#L12
When everything is converted into alcotest, we can undo that change, as it only shows the output of failed tests.

@lindig lindig merged commit 76ed723 into xapi-project:master Jan 31, 2018
@gaborigloi gaborigloi deleted the alcotest_vm_check branch January 31, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants