Fix issue #4491: USB device reset for Privileged VMs #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremfg
force-pushed
the
Fix4491_privileged_usb_reset
branch
from
c922f91
to
2085ce1
Compare
…h PCI device attached) is not working due to bad argument '-r' Signed-off-by: Jérémie Faucher-Goulet <jeremiefauchergoulet@hotmail.com>
jeremfg
force-pushed
the
Fix4491_privileged_usb_reset
branch
from
2085ce1
to
9d8f5bb
Compare
|
Do the VMs that gave you trouble boot successfully with this change? |
lippirk
approved these changes
Aug 9, 2021
Yes. I've kept the change locally and use this. |
psafont
approved these changes
Aug 9, 2021
lindig
added a commit
to lindig/xen-api
that referenced
this pull request
Aug 12, 2021
…ileged_usb_reset Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
lindig
added a commit
to lindig/xen-api
that referenced
this pull request
Aug 12, 2021
…ileged_usb_reset Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VM has PCI devices attached, xenopsd will call a usb reset with parameter "-r" for USB passthrough devices to indicate a privileged VM.
xen-api doesn't parse option "-r" properly and is wrongly expecting an integer. This PR fixes this.