IH-543: Add IPMI DCMI based power reading rrdd plugin #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
force-pushed
the
private/edvint/dcmi
branch
2 times, most recently
from
c58ff84
to
f03cc14
Compare
Vincent-lau
approved these changes
Apr 16, 2024
psafont
reviewed
Apr 16, 2024
duobei
reviewed
Apr 17, 2024
edwintorok
force-pushed
the
private/edvint/dcmi
branch
from
f03cc14
to
1b27cd4
Compare
lindig
approved these changes
Apr 17, 2024
robhoes
reviewed
Apr 18, 2024
|
Commits 2–5 essentially look like fixups... squash'em? |
edwintorok
force-pushed
the
private/edvint/dcmi
branch
from
9019124
to
139ccde
Compare
lindig
reviewed
Apr 22, 2024
That's not great title for a commit :) |
|
CI says |
edwintorok
force-pushed
the
private/edvint/dcmi
branch
from
139ccde
to
0b0a4a5
Compare
|
Thanks for spotting, updated. |
Guard against buggy firmware by ignoring 0 or 65535 Watts (although xcp-rrdd doesn't actually correctly ignore these yet). Future-proof plugin by parsing Watts as float, although currently it is always an integer in the DCMI spec. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/dcmi
branch
from
0b0a4a5
to
22d20ed
Compare
lindig
reviewed
Apr 22, 2024
lindig
approved these changes
Apr 23, 2024
pytype_reporter extracted 47 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Dell PowerEdge R750, and a few other systems seem to have this data too, e.g. SuperMicro.
Draft pull request, because there are occasional issues where ipmitool fails to report anything (usually happens if you query it too often in a row), but seems fine with the 5s interval:
Starting a workload on an otherwise idle system resulted in an increase from 309W to 489W, so it seems to be working.
We might want to do a bit more sanity testing, e.g. there are known buggy firmwares that always return 0 W or 65535 W, and we should stop running in that case if that happens right after we call 'discover'.
Also XenCenter doesn't recognize the units (W), so that might need some work.