Routine feature branch sync #5568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add standard http attributes to from opentelemetry such as: - `http.request.method` - `http.request.header.content-type`; - `http.request.body.size`; - `http.request.header.user-agent`; - `http.request.header.(key)`. This improves debuggability associated with client requests. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
Signed-off-by: Lunfan Zhang <Lunfan.Zhang@cloud.com>
Protocol_unix spawns a new thread for each request and already processes requests concurrently.
However Protocol_{lwt,async} was waiting for each request to be fully processed before fetching and dispatching the next one.
Change `iter` to `iter_donwait`, run all promises in parallel, and don't wait for any of them to complete.
Exceptions have to go somewhere though, so set up an Lwt.async_exception_hook that logs the exception.
Note: this might need some throttling so that sending lots of RPC calls doesn't cause the server to run OOM.But Protocol_unix already has this problem.
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Previously we had problems with making message switch process multiple messages at the same time, especially with the xapi-storage-script. It would still be good to have this feature, but be more conservative and make it off by default. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…witch-optional CP-47033: Make message switch concurrent processing optional
OTEL_RESOURCE_ATTRIBUTES is in W3CBaggageFormat and thus uses %. ConfigParser attempts to interpolate these % signs but we want them to be left alone, so set interpolation=None Signed-off-by: Steven Woods <steven.woods@citrix.com>
…-391485 CA-391485: Avoid InterpolationSyntaxError by turning off interpolation
A recent change added the dependency Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
There's no need for suffix, Ocaml has different namespace for types. This was suggested as part of a code review. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
…wer! Don't use string comparisons for versions, "17" < "2", but 17 > 2! Signed-off-by: Edwin Török <edwin.torok@cloud.com>
…enver xenopsd: fix Xen version comparison. 4.17 is > 4.2, not lower!
…CP-47660 CP-47660 define anti-affinity feature
Not only print the time taken for program execution but also check the process was stopped not too early and not too late. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
Signed-off-by: Mark Syms <mark.syms@citrix.com>
Add standard http attributes to from opentelemetry such as: - `network.local.address`; - `network.local.port`; - `network.peer.address`; - `network.peer.port`. This improves debuggability associated with client requests. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
minglumlu
approved these changes
Apr 18, 2024
gangj
approved these changes
Apr 18, 2024
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.