-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-47302: VM start with anti-affinity #5577
Merged
robhoes
merged 2 commits into
xapi-project:feature/vm-anti-affinity
from
BengangY:private/bengangy/CP-47302
Apr 25, 2024
Merged
CP-47302: VM start with anti-affinity #5577
robhoes
merged 2 commits into
xapi-project:feature/vm-anti-affinity
from
BengangY:private/bengangy/CP-47302
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79ce511
to
c158a72
Compare
minglumlu
reviewed
Apr 22, 2024
minglumlu
reviewed
Apr 22, 2024
minglumlu
reviewed
Apr 22, 2024
minglumlu
reviewed
Apr 22, 2024
duobei
reviewed
Apr 22, 2024
minglumlu
reviewed
Apr 22, 2024
minglumlu
reviewed
Apr 22, 2024
gangj
reviewed
Apr 22, 2024
duobei
reviewed
Apr 22, 2024
gangj
reviewed
Apr 22, 2024
gangj
reviewed
Apr 22, 2024
c158a72
to
9909216
Compare
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
For the 1st commit: "CP-47302: VM start with anti-affinity", would you please add some descriptions about the anti-affinity rules for VM start: how a host is chosen for anti-affinity VM. For the 2nd commit, the commit message would be better as: |
9909216
to
f0d6241
Compare
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 23, 2024
gangj
reviewed
Apr 24, 2024
50af2b2
to
5228bf4
Compare
gangj
reviewed
Apr 24, 2024
gangj
reviewed
Apr 24, 2024
gangj
reviewed
Apr 24, 2024
d777784
to
e6102d5
Compare
gangj
reviewed
Apr 24, 2024
gangj
reviewed
Apr 24, 2024
gangj
reviewed
Apr 24, 2024
gangj
reviewed
Apr 24, 2024
e6102d5
to
91ee946
Compare
gangj
reviewed
Apr 24, 2024
91ee946
to
c419275
Compare
gangj
approved these changes
Apr 24, 2024
robhoes
reviewed
Apr 24, 2024
gangj
reviewed
Apr 24, 2024
d15d63c
to
6c835fb
Compare
gangj
reviewed
Apr 25, 2024
VM in an anti-affinity group will choose a host based on the following steps: 1. If the VM is associated with an anti-affinity group, compute the number of VMs associated with this anti-affinity group for each host. 2. Group these hosts based on the VM's count. The hosts in one group have the same number of VMs in one anti-affinity group. Sort all the host groups ascending based on the VM's count. 3. If a host is the affinity host of this VM, it will be treated as a single host group and be put on the head of the group list. 4. Choose a host randomly which the VM can run on it from each group. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
gangj
reviewed
Apr 25, 2024
6c835fb
to
d438adb
Compare
minglumlu
approved these changes
Apr 25, 2024
robhoes
reviewed
Apr 25, 2024
Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
d438adb
to
0de00ba
Compare
robhoes
approved these changes
Apr 25, 2024
aeac4cc
into
xapi-project:feature/vm-anti-affinity
13 checks passed
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM in an anti-affinity group will choose a host based on the following steps:
of VMs associated with this anti-affinity group for each host.
amount are in the same group. Sort all the host groups ascending based on
the VM's amount.
host group and be put on the head of the group list.